Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Site title and hamburger menu overlap in mobile view #58

Closed
rpodcast opened this issue Apr 27, 2017 · 5 comments
Closed

[Bug] Site title and hamburger menu overlap in mobile view #58

rpodcast opened this issue Apr 27, 2017 · 5 comments
Assignees
Labels

Comments

@rpodcast
Copy link
Contributor

rpodcast commented Apr 27, 2017

I pulled up the sample castanet site on my LG G4 android phone (browser is chrome for android) and I saw that the site title HugoCast and the "hamburger" icon (I'm sure there's a more technical name for this) were overlapping each other in the top center of the page view. Here's a screenshot

screenshot_2017-04-27-01-26-27

I'm fairly certain this only happened after your recent update to bootstrap 4 because I viewed my podcast site r-podcast.org on my phone and the site title is left-justified while the hamburger menu is right-justified.

Reproduction Steps: Load site in a small viewport

@mattstratton
Copy link
Owner

Oddly, this only seems to happen in Chrome with dev tools (I saw it there in the smaller viewport emulator) but not on mobile safari. I'll investigate it shortly.

img_4031

@ghost
Copy link

ghost commented Apr 27, 2017

Your issue doesn't follow our guidelines. Please fix the following:

  • Issue description must include reproduction steps (?)

Click here for details.

Thank you! 🙏

This comment was made by GitMagic – Magically enforcing your contribution guidelines.

@mattstratton
Copy link
Owner

@Thercast - ignore the aggressive bot :)

@ghost
Copy link

ghost commented Apr 27, 2017

Thank you, everything looks good now! :bowtie:

@mattstratton
Copy link
Owner

So I did find a workaround - the issue comes up when the nav contains a container, to make the navigation align with the middle container. When I remove that container, it makes the hamburger menu work fine.

I am thinking I'll commit this particular fix and open a new issue to get the navigation aligned properly.

@ghost ghost assigned mattstratton Apr 27, 2017
@ghost ghost added the in progress label Apr 27, 2017
@ghost ghost removed the in progress label Apr 27, 2017
@mattstratton mattstratton modified the milestone: v.1.0 May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants