Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - misleading themesdir inside exampleSite -> config.toml #286

Closed
tcarreira opened this issue Aug 21, 2020 · 4 comments
Closed

[BUG] - misleading themesdir inside exampleSite -> config.toml #286

tcarreira opened this issue Aug 21, 2020 · 4 comments
Labels

Comments

@tcarreira
Copy link

Describe the bug
There should be no themesdir directive inside config.toml file (exampleSite directory)

If the line themesdir = "../.." is present on my config.toml file, I get an error

To Reproduce
1.

git submodule add -f https://github.com/mattstratton/castanet.git themes/castanet
  1. copy the content from ./themes/exampleSite/config.toml to ./config.toml
  2. run hugo server
  3. error:
$ hugo server
Error: module "castanet" not found; either add it as a Hugo Module or store it in "/home/tcarreira".: module does not exist

Expected behavior
I was expecting to get a running website with the example provided

Desktop (please complete the following information):

  • OS: Linux - Ubuntu 20.04
  • Hugo version: Hugo Static Site Generator v0.74.3 linux/amd64 BuildDate: 2020-07-23T20:37:11Z

Additional context
I'm using Hugo for the first time, so I might be doing something wrong here, but after removing that line from my config.toml, everything is running.

@tcarreira tcarreira added the bug label Aug 21, 2020
tcarreira added a commit to tcarreira/castanet that referenced this issue Aug 21, 2020
tcarreira added a commit to tcarreira/castanet that referenced this issue Aug 21, 2020
@tcarreira
Copy link
Author

I've created #287, but I'm still not sure if I was doing something wrong 😅

@mattstratton
Copy link
Owner

This is needed in order to run the exampleSite. You shouldn't copy that part, but the examplesite directory needs it in order to run properly for the Hugo showcase, tests, etc.

@tcarreira
Copy link
Author

tcarreira commented Aug 22, 2020

Ok, I think this would be a Creator's decision in the end.

Just for reference: https://themes.gohugo.io/hugo-clarity/#option-1-recommended
It is possible to do what you need with hugo server --themesDir ../.. and still have a completely functional exampleSite.

If you still keep that directive, I would suggest adding a note on how to install it (and copy the necessary files) as a theme in the README instructions.

And thank you for you help 😃

A theme based on VMware's Clarity Design System for publishing technical blogs with Hugo.

@mattstratton
Copy link
Owner

Totally get that. I think also the instructions for the theme don't say to copy the config.toml, but to use it as a reference. I could make that more clear in the README however to that effect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants