Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve favicon implementation #234

Closed
mattstratton opened this issue Nov 23, 2019 · 0 comments · Fixed by #288
Closed

Improve favicon implementation #234

mattstratton opened this issue Nov 23, 2019 · 0 comments · Fixed by #288
Assignees
@mattstratton
Labels
enhancement

Comments

@mattstratton
Copy link
Owner

Ideally, it should work with the solution provided at https://realfavicongenerator.net/

The code that should end up in <head> is:

<link rel="apple-touch-icon" sizes="144x144" href="/apple-touch-icon.png">
<link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png">
<link rel="manifest" href="/site.webmanifest">
<link rel="mask-icon" href="/safari-pinned-tab.svg" color="#5bbad5">
<meta name="msapplication-TileColor" content="#da532c">
<meta name="theme-color" content="#ffffff">
@mattstratton mattstratton self-assigned this Nov 23, 2019
darinpope added a commit to darinpope/castanet that referenced this issue Aug 22, 2020
@darinpope
fixes mattstratton#234
1449b0c 
This implementation is based on taking all the defaults from https://realfavicongenerator.net/

Signed-off-by: Darin Pope <[email protected]>
@darinpope darinpope mentioned this issue Aug 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattstratton mattstratton

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve favicon implementation darinpope/castanet
1 participant
@mattstratton