Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host display should be a partial #158

Closed
mattstratton opened this issue Mar 7, 2018 · 2 comments
Closed

Host display should be a partial #158

mattstratton opened this issue Mar 7, 2018 · 2 comments
Assignees
@mattstratton
Labels
enhancement needs-review
Milestone
Sprint 1

Comments

@mattstratton
Copy link
Owner

mattstratton commented Mar 7, 2018 •
edited
Loading

Instead of all the duplicated code, I suggest creating a shortcode to allow the insertion of the host list.

UPDATE - changing to be a partial not a shortcode
@mattstratton mattstratton self-assigned this Mar 7, 2018
@mattstratton mattstratton added this to the Sprint 1 milestone Mar 7, 2018
@mattstratton
Copy link
Owner Author

Make sure to update the REFERENCE file with this shortcode.

@mattstratton
Copy link
Owner Author

Upon reflection, this worked out better to make it a partial. Updating the title of the issue to reflect this.

@mattstratton mattstratton changed the title Host display should be a shortcode Host display should be a partial Mar 7, 2018
mattstratton added a commit that referenced this issue Mar 7, 2018
@mattstratton
Update host code to be a partial
7dfd19a 
Fixes #158

Signed-off-by: Matt Stratton <[email protected]>
@ghost ghost added the in progress label Mar 7, 2018
@mattstratton mattstratton mentioned this issue Mar 7, 2018
Merged
@ghost ghost added needs-review and removed in progress labels Mar 7, 2018
mattstratton added a commit that referenced this issue Mar 7, 2018
@mattstratton
Update host code to be a partial (#166)
20037c8 
* Update host code to be a partial

Fixes #158

Signed-off-by: Matt Stratton <[email protected]>

* Check for enable_jumbo exist for sidebar display

fixes #167

Signed-off-by: Matt Stratton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattstratton mattstratton

Labels
enhancement needs-review
Projects
None yet
Milestone
Sprint 1
Development

No branches or pull requests
1 participant
@mattstratton