-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize placement of "Read More" #116
Comments
I can definitely see where it would be useful to set your own truncate value; it should be fairly trivial to do (the truncate code is super simple compared to how I was doing it in another theme), so I'll we'll work on it! |
Okay I read this again, and I misunderstood the requirement. You would like more control over where the summary occurs. I believe there is a way to handle this natively in Hugo; I'll dig into it. The issue that I think occurs is that the "summary" won't show up (or it does show up, I don't recall) in the description. I understand that a 600 character truncate on description is opinionated (and was arbitrary) so maybe it can be something that is optional per epiosde. I also wonder if your description is over this amount if it's took long in general :) |
I had some time to think more about it. For one case, it would be great to just be able to customize the 600 limit on a per-episode basis. Though my other want would be to enable the "Read More" link to appear after the entire episode description, no matter how many characters it happens to be. That would make it a convenient way for the user to bring up the detailed notes right after reading the description. Might be too esoteric so I understand if that's not what you plan to build in. FYI I finally got my site up-to-date with your lastest-ish theme files and it looks fantastic! Head to https://r-podcast.org/ if you want to have a look (repo is here). Thanks again for your awesome work on this theme. |
Looks great! Amusingly enough, I added the "list of guests" page to the theme today, before looking at your site. Great minds think alike! |
So thinking this through...the idea is that there is a new frontmatter element like this:
And it will truncate that particular episode at that level. I'm wondering if it's better to make this a global configuration value; rather than doing it on a per-episode basis (having done 85 episodes of ADO, I can't imagine trying to puzzle out where I want it to cut off for each one) but rather saying "OK, Matt, I see why you like it to truncate at 600 runes, but I prefer 900". So if it's set in I suppose it would be possible to do both, as well...allow a global override, but also a per-episode override? Thoughts? |
Hey sorry for getting back to you late on this. Ideally I'd prefer both ways (global override but also an optional per-episode option in the frontmatter). I certainly don't want to force others (especially yourself) to have to make this config in each episode's options retroactively! |
I really like the Read More feature when rendering the episode descriptions in the episode rows. For some of my episode descriptions I'd like to insert the Read More prompt earlier than the 600 character mark (I believe I'm interpreting that limit correctly when viewing the row.html partial. I can think of a couple of ways to accomplish this:
Certainly not an urgent feature but down the road it might be nice to have it.
The text was updated successfully, but these errors were encountered: