Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON.stringify will omit deleted keys in the result because they are set to undefined #78

Open
jchip opened this issue Feb 25, 2022 · 2 comments
Open

JSON.stringify will omit deleted keys in the result because they are set to undefined #78

jchip opened this issue Feb 25, 2022 · 2 comments

Comments

@jchip
Copy link

jchip commented Feb 25, 2022

When you JSON.stringify an object, it omit keys that has undefined value.

That means for the result coming back from deletedDiff needs a replacer for JSON.stringify to keep the key.

It's a small thing, but if you were not aware of it, like I did, you get tripped by it.
@avimar
Copy link

avimar commented Mar 28, 2022

Sounds like #10 with a solution: #10 (comment)

As referenced from #76 (comment)

@gregfenton
Copy link

Can this be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@avimar @gregfenton @jchip