Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

old /x/sys package produces error while compiling #52

Open
shif3r opened this issue Apr 21, 2020 · 4 comments · May be fixed by #87
Open

old /x/sys package produces error while compiling #52

shif3r opened this issue Apr 21, 2020 · 4 comments · May be fixed by #87

Comments

@shif3r
Copy link

shif3r commented Apr 21, 2020

Description

I was trying to use docker cli by fsouza in my project but it produces an error when i compile it.
golang/go#34610

How to reproduce

package main

import "github.com/fsouza/go-dockerclient"

func main() {
	if _, err := docker.NewClientFromEnv(); err != nil {
		panic(err)
	}
}

module exex.org/helpme

go 1.14

require (
	github.com/fsouza/go-dockerclient v1.6.4
	github.com/mattn/go-isatty v0.0.12 // indirect
)

Expectations

normal compile

Actual result

..\..\go\pkg\mod\github.com\docker\[email protected]\pkg\system\filesys_windows.go:112:24: cannot use uintptr(unsafe.Pointer(&sd[0])) (ty
pe uintptr) as type *"golang.org/x/sys/windows".SECURITY_DESCRIPTOR in assignment

Environment

  • go version: 1.14.2
  • operating system: Windows 10
@mattn
Copy link
Owner

mattn commented Apr 21, 2020

As far as I can see, it's not depend on go-isatty. It's possible to reproduce without go-isatty.

2 similar comments
@mattn
Copy link
Owner

mattn commented Apr 21, 2020

As far as I can see, it's not depend on go-isatty. It's possible to reproduce without go-isatty.

@mattn
Copy link
Owner

mattn commented Apr 21, 2020

As far as I can see, it's not depend on go-isatty. It's possible to reproduce without go-isatty.

@shif3r
Copy link
Author

shif3r commented Apr 21, 2020

The problem is, what my service is using a gin package which has depends on isatty. I tried to automate creating docker containers and get this error. Anyway, i think it's a problem, what your library isn't using latest /x/sys package

abitrolly added a commit to abitrolly/go-isatty that referenced this issue Aug 3, 2024
@abitrolly
Update golang.org/x/sys dependency
3e0c9d1 
go get -u all
go mod tidy

Fixes mattn#52
@abitrolly abitrolly linked a pull request Aug 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update golang.org/x/sys dependency abitrolly/go-isatty
2 participants
@mattn @shif3r