Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anon calls doesn't report the expr position #336

Closed
dgrr opened this issue May 4, 2020 · 4 comments
Closed

Anon calls doesn't report the expr position #336

dgrr opened this issue May 4, 2020 · 4 comments

Comments

@dgrr
Copy link

dgrr commented May 4, 2020

Hello,

The anon calls (for example MemberExpr calls) don't report the expression position.
Take a look here, there's nothing setting the position to the CallExpr. If you want to see a fix take a look here.

Thanks.

@MichaelS11
Copy link
Contributor

Want to make a PR? Can position be set on CallExpr create?

@dgrr
Copy link
Author

dgrr commented May 5, 2020

I can't make a pull request because my fork is incompatible with anko. As far as I see, the position cannot be set on CallExpr create because pos is private

@MichaelS11
Copy link
Contributor

If you really do want to do a PR, you can setup a new branch on your fork, pull from main Anko branch on to the new branch , then do a force push to the new branch. Then do a PR from that new branch.

@MichaelS11
Copy link
Contributor

#340

@dgrr dgrr closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants