diff --git a/setup.py b/setup.py index 5a9bbb74..d78413d4 100644 --- a/setup.py +++ b/setup.py @@ -77,7 +77,26 @@ def run(self): with open(eigentarpath, 'wb') as f: f.write(r.content) with tarfile.open(eigentarpath, 'r') as tar: - tar.extractall('deps') + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, "deps") thedir = glob(os.path.join('deps', 'eigen-*'))[0] shutil.move(os.path.join(thedir, 'Eigen'), eigenpath) print('...done!')