Update node-fetch to ^2.0.0 (major change)
#157
Conversation
This will change the behavior of `isomorphic-fetch` if imported in a Node.js environment. The actual major changes can be found in the `2.0.0` release notes of node-fetch. See: https://github.com/bitinn/node-fetch/blob/master/CHANGELOG.md#v200
|
That error confuses me. Why is it checking files in the dependencies? Is that intentional? |
|
Any word on this? |
|
@leoselig Thank you for contributing this PR. That would be really great to have. |
|
I'd love to have |
|
@matthew-andrews Would like to see this land. Can you release this, please? |
|
There have been several new releases since |
|
I started on new fetch which uses node-fetch 2.x https://github.com/codler/fetch-register |
|
@matthew-andrews could you support us with this issue, please. |
|
v1 is not spec compliant in regards to utf-8, please can we land this? https://github.com/bitinn/node-fetch/blob/master/CHANGELOG.md#response-and-request-classes |
|
This has been resolved in master … sorry for the huge delay. I will release as a major version soon, please test against your applications. |
This will change the behavior of
isomorphic-fetchif imported in aNode.js environment. The actual major changes can be found in the
2.0.0release notes of node-fetch.See: https://github.com/bitinn/node-fetch/blob/master/CHANGELOG.md#v200
Overall, this should increase the usefulness of
isomorphic-fetchby a lot since version 2 aligns the implementation with the spec for a lot of issues. For instance, I expect this to fix:.arrayBuffer()is not supportedheaders.forEach