Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use batch requests in the Daily Summary job to improve performance #48

Closed
mickmister opened this issue Mar 6, 2020 · 0 comments · Fixed by #72
Closed

Use batch requests in the Daily Summary job to improve performance #48

mickmister opened this issue Mar 6, 2020 · 0 comments · Fixed by #72
Assignees
@mickmister
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature

Comments

@mickmister
Copy link
Contributor

Summary

As of #36, the daily summary job does a separate http request for each user to gather the calendar data.

If we instead queue up which users need their daily summaries "now", then use batch requests to send them in a 20-request batch, this will tremendously improve the performance. You can find example code using batch requests in the GetSchedule method in the remote/msgraph package.
@mickmister mickmister added Enhancement Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers labels Mar 6, 2020
@hanzei hanzei added Type/Enhancement New feature or improvement of existing feature and removed Enhancement labels Mar 7, 2020
@mickmister mickmister removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Mar 16, 2020
@mickmister mickmister self-assigned this Mar 16, 2020
@mickmister mickmister mentioned this issue Mar 16, 2020
Closed
@mickmister mickmister mentioned this issue Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mickmister mickmister

Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use batch requests for daily summary job mattermost/mattermost-plugin-mscalendar
2 participants
@mickmister @hanzei