Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version showing incorrectly #136

Closed
chenilim opened this issue Mar 19, 2021 · 1 comment
Closed

Version showing incorrectly #136

chenilim opened this issue Mar 19, 2021 · 1 comment
Labels
Bug Something isn't working

Comments

@chenilim
Copy link
Contributor

Summary:
The version is displayed as 0.6.0 even in the 0.6.1 build

Steps to reproduce the behavior:

  1. Install 0.6.1 and open web app
  2. Version shows 0.6.0

Expected behavior:
Show 0.6.1

Platform:

  • Chrom 89 on macOS 10.15.7

Additional context:
Even though this is just cosmetic, we should fix this to make consistent future updates easier. At the moment, the version string is hardcoded in several places:

  • webapp/src/constants.ts (this is the one displayed by the webapp)
  • webapp/package.json (not actually used)
  • server/model/version.go (this is displayed by the server at boot)
  • mac/Focalboard/Info.plist (used by the Mac app)
  • win-wpf/AppxManifest.xml (used by the Windows app)

Ideally, this should be stamped at build-time, but for now, let's keep them in sync manually.

@chenilim chenilim added the Bug Something isn't working label Mar 19, 2021
@chenilim
Copy link
Contributor Author

Additional note for the future: Technically, the server can and should have an independent version from the clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant