Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zkstack readme update broken links and wording #3375

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

zk-Lumi
Copy link
Contributor

@zk-Lumi zk-Lumi commented Dec 10, 2024

What ❔

Hi @Deniallugo @popzxc πŸ‘‹

Was playing with zkstack cli today.

This PR is just fixing a couple of broken links and updating a bit of wording in zkstack_cli/README.md.

PS: sidenote, "EVM emulator" is not explained in this readme, and "Enable EVM emulator?" in interactive mode will be confusing to people (they likely wont realize that it is emulating EVM equivalence but not required for most chains + will be more expensive)

Why ❔

Possibly a bit OCD, ie "Zk" being wrongly cased in one instance stayed in my mind and bothered me hahahah πŸ˜‰

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@zk-Lumi zk-Lumi changed the title fix: zkstack readme update broken links & some wording fix: zkstack readme update broken links and wording Dec 10, 2024
@popzxc
Copy link
Member

popzxc commented Dec 12, 2024

PS: sidenote, "EVM emulator" is not explained in this readme, and "Enable EVM emulator?" in interactive mode will be confusing to people (they likely wont realize that it is emulating EVM equivalence but not required for most chains + will be more expensive)

cc @sanekmelnikov

@popzxc popzxc added this pull request to the merge queue Dec 12, 2024
Merged via the queue into matter-labs:main with commit ee117a8 Dec 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants