feat: integrate gateway changes for some components #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
reviewed
Nov 18, 2024
core/lib/l1_contract_interface/src/i_executor/methods/commit_batches.rs
Outdated
Show resolved
Hide resolved
core/lib/l1_contract_interface/src/i_executor/methods/commit_batches.rs
Outdated
Show resolved
Hide resolved
core/node/node_framework/src/implementations/layers/query_eth_client.rs
Outdated
Show resolved
Hide resolved
tomg10
reviewed
Nov 18, 2024
core/node/eth_watch/src/event_processors/appended_chain_batch_root.rs
Outdated
Show resolved
Hide resolved
tomg10
previously approved these changes
Nov 25, 2024
tomg10
approved these changes
Nov 27, 2024
This was referenced Nov 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
🤖 I have created a release *beep* *boop* --- ## [25.3.0](core-v25.2.0...core-v25.3.0) (2024-12-11) ### Features * change seal criteria for gateway ([#3320](#3320)) ([a0a74aa](a0a74aa)) * **contract-verifier:** Download compilers from GH automatically ([#3291](#3291)) ([a10c4ba](a10c4ba)) * integrate gateway changes for some components ([#3274](#3274)) ([cbc91e3](cbc91e3)) * **proof-data-handler:** exclude batches without object file in GCS ([#2980](#2980)) ([3e309e0](3e309e0)) * **pruning:** Record L1 batch root hash in pruning logs ([#3266](#3266)) ([7b6e590](7b6e590)) * **state-keeper:** mempool io opens batch if there is protocol upgrade tx ([#3360](#3360)) ([f6422cd](f6422cd)) * **tee:** add error handling for unstable_getTeeProofs API endpoint ([#3321](#3321)) ([26f630c](26f630c)) * **zksync_cli:** Health checkpoint improvements ([#3193](#3193)) ([440fe8d](440fe8d)) ### Bug Fixes * **api:** batch fee input scaling for `debug_traceCall` ([#3344](#3344)) ([7ace594](7ace594)) * **tee:** correct previous fix for race condition in batch locking ([#3358](#3358)) ([b12da8d](b12da8d)) * **tee:** fix race condition in batch locking ([#3342](#3342)) ([a7dc0ed](a7dc0ed)) * **tracer:** adds vm error to flatCallTracer error field if exists ([#3374](#3374)) ([5d77727](5d77727)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Generally moves some code from gateway integration branch into main. High-level list of changes:
eth_watch: refactors watcher's client so it can use L2-specific features if gateway is queried. New event processor is added for chains that settle on gateway, it calculates part of merkle proof for L2->L1 logs.api: new method is added tounstablenamespace that is utilized by the new event processor. This method encapsulates a few storage reads + builds merkle tree. This is a temporary measure and method will likely be removed (that's why it's in unstable namespace) pretty soon after a contract getter that does exactly the same is merged into contracts, replacing unstable_getChainLogProof invocation with a simpleeth_callconsistency_checker,tree_data_fetcher: adds support for reading batch commitment from either L1 or GW depending on what the SL is for a batch.L2_NATIVE_TOKEN_VAULT_ADDRESSwas used instead ofL2_ASSET_ROUTER_ADDRESSincore/bin/external_node/src/node_builder.rs, mixed up if/else branches incore/node/commitment_generator/src/lib.rsresolve_l1_batch_to_l2_block+get_block_detailsare replaced with justget_batch_detailsinbatch_status_updater, some code for old protocol versions (pre-boojum or pre-shared-bridge) removed,l1_prefix is added to some addresses to avoid confusionWhy ❔
Finalize and merge some gateway features
Checklist
zkstack dev fmtandzkstack dev lint.