Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(zkstack_cli): Use the same rust toolchain as main repo #3230

Merged
merged 5 commits into from
Nov 7, 2024
Merged

feat(zkstack_cli): Use the same rust toolchain as main repo #3230

merged 5 commits into from
Nov 7, 2024

Conversation

manuelmauro
Copy link
Contributor

@manuelmauro manuelmauro commented Nov 5, 2024 •
edited
Loading

What ❔

Add linting target for Rust toolchains.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@manuelmauro manuelmauro marked this pull request as ready for review November 5, 2024 15:51
@manuelmauro manuelmauro requested a review from a team as a code owner November 5, 2024 15:51
@Deniallugo Deniallugo enabled auto-merge November 6, 2024 16:02
@Deniallugo Deniallugo added this pull request to the merge queue Nov 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2024
@Deniallugo Deniallugo added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit e69d15b Nov 7, 2024
32 checks passed
@Deniallugo Deniallugo deleted the manuel-use-the-same-rust-toolchain-as-main-repo branch November 7, 2024 04:10
@zksync-era-bot zksync-era-bot mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otani88 otani88 otani88 approved these changes

@Deniallugo Deniallugo Deniallugo approved these changes

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelmauro @Deniallugo @otani88