Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zkstack_cli): use docker-managed volumes #3140

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

itegulov
Copy link
Contributor

What ❔

Host-bound volumes never get cleaned even if you do docker compose down -v. Existing dev flows don't seem to rely on volumes being on the host machine, so this is PoC of how we can move to Docker-managed volumes.

Why ❔

Avoid pesky bugs that prevent user from deleting ./volumes, rely on Docker to persist and dispose of data as need be

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@itegulov itegulov force-pushed the daniyar/zkstack/docker-volumes branch 3 times, most recently from b5c9b93 to 5c279ae Compare October 21, 2024 12:50
@itegulov itegulov force-pushed the daniyar/zkstack/docker-volumes branch from 5c279ae to 7590621 Compare October 21, 2024 12:57
@Deniallugo Deniallugo marked this pull request as ready for review October 24, 2024 09:42
@Deniallugo Deniallugo requested a review from a team as a code owner October 24, 2024 09:42
@Deniallugo Deniallugo added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit ee73a39 Oct 24, 2024
43 checks passed
@Deniallugo Deniallugo deleted the daniyar/zkstack/docker-volumes branch October 24, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants