feat(zk_toolbox): improved wallet handling #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
previously approved these changes
Oct 10, 2024
Deniallugo
reviewed
Oct 10, 2024
Deniallugo
approved these changes
Oct 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the tool fail with an error when wallets.yaml has parsing errors, rather than displaying "not found".
Made the tool fail when the wallets.yaml is unparseable instead of blindly overwriting it (in Localhost mode).
Made the tool check that the address actually matches the private key when parsing the config.
Made the tool check that the private key is actually a valid private key when parsing the config.
Made the code pass around Wallet, rather than weakly typed H256.