Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zk_toolbox): allow hyphens after zks test rust --options #3043

Merged
merged 3 commits into from
Oct 9, 2024
Merged

fix(zk_toolbox): allow hyphens after zks test rust --options #3043

merged 3 commits into from
Oct 9, 2024

Conversation

itegulov
Copy link
Contributor

@itegulov itegulov commented Oct 9, 2024

What ❔

Forces clap to allow hyphens after zks test rust --options

Why ❔

So that you can run sensible commands like zks test rust --options "-E test(io::tests::continue_unsealed_batch_on_restart) --no-capture"

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk_supervisor fmt and zk_supervisor lint.

@itegulov itegulov requested a review from Deniallugo October 9, 2024 09:03
Deniallugo
Deniallugo previously approved these changes Oct 9, 2024
View reviewed changes
@itegulov itegulov enabled auto-merge October 9, 2024 09:09
@itegulov itegulov added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 9450c50 Oct 9, 2024
31 checks passed
@itegulov itegulov deleted the daniyar/allow-hyphens-zk-toolbox branch October 9, 2024 11:13
@zksync-era-bot zksync-era-bot mentioned this pull request Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deniallugo Deniallugo Deniallugo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itegulov @Deniallugo