Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(da-clients): add Celestia client #2983

Merged
merged 23 commits into from
Oct 29, 2024
Merged

Conversation

dimazhornyk
Copy link
Contributor

@dimazhornyk dimazhornyk commented Sep 30, 2024

What ❔

This PR adds a Celestia DA client.
The main complexity of this PR comes from our goal to lower the operational load and not run the Celestia light node (which is a default way of interacting with Celestia blockchain).

This was done by adapting Astria's Celestia client implementation to our codebase and removing unneeded logical components.

Note that Celestia's main communication protocol is gRPC, which means we have to import or maintain the proto definitions. I decided to reuse the generated .rs files from Astria's repo to remove the need to maintain the .proto files in our repo (not the cleanest way, but consider it a rather temporary solution).
There is a celestia-proto crate that has all the codegen that we need, but they don't generate the gRPC client definitions, only the types, so we can't use them atm. I will try to ask the team maintaining it to add such an option, then we would be able to remove all the codegen from our repo, and simply import it from celestia-proto.

Example config:

da_client:
  celestia:
    api_node_url: http://grpc-mocha.pops.one:9090
    namespace: 000000000000000000000000000000000000ca1de12a5e2d5beb9ba9
    chain_id: mocha-4
    timeout_ms: 10000

secrets:

da:
  celestia:
    private_key: PRIVATE_KEY_WITHOUT_0x_PREFIX

Why ❔

To enable Celestia DA in ZK stack

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@dimazhornyk dimazhornyk marked this pull request as ready for review October 11, 2024 16:19
@zvolin
Copy link

zvolin commented Oct 14, 2024

There is a celestia-proto crate that has all the codegen that we need, but they don't generate the gRPC client definitions, only the types, so we can't use them atm. I will try to ask the team maintaining it to add such an option, then we would be able to remove all the codegen from our repo, and simply import it from celestia-proto.

Hey, we should be able to add this to celestia-proto, maybe behind some feature flag 🤔. It would be cool if you could open us an issue providing further details, which grpcs are needed, and how you would want those generated (tonic?)

Copy link
Contributor

@perekopskiy perekopskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I see that compilation for unit tests increased from 9 to 11 minutes in this PR but in PR with eigen where tonic default features are removed it's 10 minutes, so it's a ~10% increase in the end (9min->10min). IMO 10% is acceptable in this case.

perekopskiy
perekopskiy previously approved these changes Oct 29, 2024
Copy link
Contributor

Detected VM performance changes

Benchmark name Est. cycles Change in est. cycles
init/fast 9145099 +4.5%

@dimazhornyk dimazhornyk added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit d88b875 Oct 29, 2024
33 checks passed
@dimazhornyk dimazhornyk deleted the dz-add-celestia-client branch October 29, 2024 12:08
github-merge-queue bot pushed a commit that referenced this pull request Nov 5, 2024
🤖 I have created a release *beep* *boop*
---


##
[25.1.0](core-v25.0.0...core-v25.1.0)
(2024-11-04)


### Features

* add `block.timestamp` asserter for AA
([#3031](#3031))
([069d38d](069d38d))
* allow vm2 tracers to stop execution
([#3183](#3183))
([9dae839](9dae839))
* **api:** get rid of tx receipt root
([#3187](#3187))
([6c034f6](6c034f6))
* **api:** Integrate new VM into API server (no tracers)
([#3033](#3033))
([8e75d4b](8e75d4b))
* base token integration tests
([#2509](#2509))
([8db7e93](8db7e93))
* **consensus:** enabled syncing pregenesis blocks over p2p
([#3192](#3192))
([6adb224](6adb224))
* **da-clients:** add Celestia client
([#2983](#2983))
([d88b875](d88b875))
* **da-clients:** add EigenDA client
([#3155](#3155))
([5161eed](5161eed))
* gateway preparation
([#3006](#3006))
([16f2757](16f2757))
* Implement gas relay mode and inclusion data for data attestation
([#3070](#3070))
([561fc1b](561fc1b))
* **metadata-calculator:** Add debug endpoints for tree API
([#3167](#3167))
([3815252](3815252))
* **proof-data-handler:** add first processed batch option
([#3112](#3112))
([1eb69d4](1eb69d4))
* **proof-data-handler:** add tee_proof_generation_timeout_in_secs param
([#3128](#3128))
([f3724a7](f3724a7))
* **prover:** Add queue metric to report autoscaler view of the queue.
([#3206](#3206))
([2721396](2721396))
* **prover:** Add sending scale requests for Scaler targets
([#3194](#3194))
([767c5bc](767c5bc))
* **prover:** Add support for scaling WGs and compressor
([#3179](#3179))
([c41db9e](c41db9e))
* **vm:** Support EVM emulation in fast VM
([#3163](#3163))
([9ad1f0d](9ad1f0d))


### Bug Fixes

* **consensus:** better logging of errors
([#3170](#3170))
([a5028da](a5028da))
* **consensus:** made attestation controller non-critical
([#3180](#3180))
([6ee9f1f](6ee9f1f))
* **consensus:** payload encoding protected by protocol_version
([#3168](#3168))
([8089b78](8089b78))
* **da-clients:** add padding to the data within EigenDA blob
([#3203](#3203))
([8ae06b2](8ae06b2))
* **da-clients:** enable tls-roots feature for tonic
([#3201](#3201))
([42f177a](42f177a))
* extend allowed storage slots for validation as per EIP-7562
([#3166](#3166))
([c76da16](c76da16))
* **merkle-tree:** Fix tree truncation
([#3178](#3178))
([9654097](9654097))
* **tee_prover:** add prometheus pull listener
([#3169](#3169))
([1ffd22f](1ffd22f))
* update logging in cbt l1 behaviour
([#3149](#3149))
([d0f61b0](d0f61b0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants