fix(zk_toolbox): fix port offset for new chains #2803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Fixed port offset for newly created chains via
zk_inception
:chain.id
instead ofchain.chain_id
(chain.id - 1) * 100
as an offset to keep the port for the first chain as 3050Why ❔
Using
chain.chain_id
was not intended as the resulting port number could potentially overflow.Checklist
zk fmt
andzk lint
.