Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zk_toolbox): fix port offset for new chains #2803

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

sanekmelnikov
Copy link
Collaborator

What ❔

Fixed port offset for newly created chains via zk_inception:

  • Use chain.id instead of chain.chain_id
  • Use (chain.id - 1) * 100 as an offset to keep the port for the first chain as 3050

Why ❔

Using chain.chain_id was not intended as the resulting port number could potentially overflow.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

Copy link
Contributor

@manuelmauro manuelmauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deniallugo Deniallugo added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 9821a20 Sep 4, 2024
22 checks passed
@Deniallugo Deniallugo deleted the sanekmelnikov/fix-offset branch September 4, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants