Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactor metrics/make API use binaries #2735

Merged
merged 13 commits into from
Aug 28, 2024
Merged

feat: Refactor metrics/make API use binaries #2735

merged 13 commits into from
Aug 28, 2024

Conversation

Artemka374
Copy link
Contributor

@Artemka374 Artemka374 commented Aug 26, 2024 •
edited
Loading

What ❔

Add metric-emitting middleware for ExternalProofIntegrationAPI
Make API return binaries/allow uploading binaries for verification

Why ❔

For better UX

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@Artemka374 Artemka374 marked this pull request as ready for review August 26, 2024 13:24
@Artemka374 Artemka374 changed the title (feat): Add metrics emitting middleware for prover API feat: Add metric-emitting middleware for prover API Aug 26, 2024
@Artemka374 Artemka374 changed the title feat: Add metric-emitting middleware for prover API feat: Refactor metrics/make API use binaries Aug 27, 2024
@Artemka374 Artemka374 requested a review from popzxc August 27, 2024 14:56
popzxc
popzxc reviewed Aug 28, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
core/node/external_proof_integration_api/src/lib.rs Show resolved Hide resolved
core/node/external_proof_integration_api/src/metrics.rs Outdated Show resolved Hide resolved
core/node/external_proof_integration_api/src/metrics.rs Outdated Show resolved Hide resolved
core/node/external_proof_integration_api/src/metrics.rs Outdated Show resolved Hide resolved
core/node/external_proof_integration_api/src/processor.rs Outdated Show resolved Hide resolved
core/node/external_proof_integration_api/src/processor.rs Outdated Show resolved Hide resolved
popzxc
popzxc reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

core/node/external_proof_integration_api/src/processor.rs Outdated Show resolved Hide resolved
core/node/external_proof_integration_api/src/processor.rs Outdated Show resolved Hide resolved
core/node/external_proof_integration_api/src/processor.rs Outdated Show resolved Hide resolved
core/node/external_proof_integration_api/src/processor.rs Show resolved Hide resolved
core/node/external_proof_integration_api/src/processor.rs Show resolved Hide resolved
core/node/external_proof_integration_api/src/middleware.rs Show resolved Hide resolved
popzxc
popzxc previously approved these changes Aug 28, 2024
View reviewed changes
popzxc
popzxc previously approved these changes Aug 28, 2024
View reviewed changes
@Artemka374 Artemka374 enabled auto-merge August 28, 2024 12:48
@Artemka374 Artemka374 added this pull request to the merge queue Aug 28, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
@Artemka374
feat: Refactor metrics/make API use binaries (#2735)
cc14d31 
## What ❔

Add metric-emitting middleware for ExternalProofIntegrationAPI
Make API return binaries/allow uploading binaries for verification

## Why ❔

For better UX

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2024
@Artemka374 Artemka374 added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 8ed086a Aug 28, 2024
48 checks passed
@Artemka374 Artemka374 deleted the afo/middleware-prover-api branch August 28, 2024 14:01
This was referenced Aug 28, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
@zksync-era-bot
chore(main): release core 24.23.0 (#2751)
64c9418 
🤖 I have created a release *beep* *boop*
---


##
[24.23.0](core-v24.22.0...core-v24.23.0)
(2024-08-28)


### Features

* Refactor metrics/make API use binaries
([#2735](#2735))
([8ed086a](8ed086a))


### Bug Fixes

* **api:** Fix duplicate DB connection acquired in `eth_call`
([#2763](#2763))
([74b764c](74b764c))
* **vm:** Fix used bytecodes divergence
([#2741](#2741))
([923e33e](923e33e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
@zksync-era-bot
chore(main): release core 24.23.0 (#2751)
3060381 
🤖 I have created a release *beep* *boop*
---


##
[24.23.0](core-v24.22.0...core-v24.23.0)
(2024-08-28)


### Features

* Refactor metrics/make API use binaries
([#2735](#2735))
([8ed086a](8ed086a))


### Bug Fixes

* **api:** Fix duplicate DB connection acquired in `eth_call`
([#2763](#2763))
([74b764c](74b764c))
* **vm:** Fix used bytecodes divergence
([#2741](#2741))
([923e33e](923e33e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
EmilLuta
EmilLuta reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very happy with the updates, thanks!

github-merge-queue bot pushed a commit that referenced this pull request Oct 31, 2024
@zksync-era-bot
chore(main): release prover 16.6.0 (#2761)
e95f50a 
🤖 I have created a release *beep* *boop*
---


##
[16.6.0](prover-v16.5.0...prover-v16.6.0)
(2024-10-31)


### Features

* (DB migration) Rename recursion_scheduler_level_vk_hash to
snark_wrapper_vk_hash
([#2809](#2809))
([64f9551](64f9551))
* Add initial version prover_autoscaler
([#2993](#2993))
([ebf9604](ebf9604))
* added seed_peers to consensus global config
([#2920](#2920))
([e9d1d90](e9d1d90))
* attester committees data extractor (BFT-434)
([#2684](#2684))
([92dde03](92dde03))
* Bump crypto and protocol deps
([#2825](#2825))
([a5ffaf1](a5ffaf1))
* **circuit_prover:** Add circuit prover
([#2908](#2908))
([48317e6](48317e6))
* **consensus:** Support for syncing blocks before consensus genesis
over p2p network
([#3040](#3040))
([d3edc3d](d3edc3d))
* **da-clients:** add secrets
([#2954](#2954))
([f4631e4](f4631e4))
* gateway preparation
([#3006](#3006))
([16f2757](16f2757))
* Integrate tracers and implement circuits tracer in vm2
([#2653](#2653))
([87b02e3](87b02e3))
* Move prover data to
/home/popzxc/workspace/current/zksync-era/prover/data
([#2778](#2778))
([62e4d46](62e4d46))
* Prover e2e test
([#2975](#2975))
([0edd796](0edd796))
* **prover:** add CLI option to run prover with max allocation
([#2794](#2794))
([35e4cae](35e4cae))
* **prover:** Add endpoint to PJM to get queue reports
([#2918](#2918))
([2cec83f](2cec83f))
* **prover:** Add error to panic message of prover
([#2807](#2807))
([6e057eb](6e057eb))
* **prover:** Add min_provers and dry_run features. Improve metrics and
test. ([#3129](#3129))
([7c28964](7c28964))
* **prover:** Add scale failure events watching and pods eviction.
([#3175](#3175))
([dd166f8](dd166f8))
* **prover:** Add sending scale requests for Scaler targets
([#3194](#3194))
([767c5bc](767c5bc))
* **prover:** Add support for scaling WGs and compressor
([#3179](#3179))
([c41db9e](c41db9e))
* **prover:** Autoscaler sends scale request to appropriate agents.
([#3150](#3150))
([bfedac0](bfedac0))
* **prover:** Extract keystore into a separate crate
([#2797](#2797))
([e239260](e239260))
* **prover:** Optimize setup keys loading
([#2847](#2847))
([19887ef](19887ef))
* **prover:** Refactor WitnessGenerator
([#2845](#2845))
([934634b](934634b))
* **prover:** Update witness generator to zkevm_test_harness 0.150.6
([#3029](#3029))
([2151c28](2151c28))
* **prover:** Use query macro instead string literals for queries
([#2930](#2930))
([1cf959d](1cf959d))
* **prover:** WG refactoring
[#3](#3)
([#2942](#2942))
([df68762](df68762))
* **prover:** WitnessGenerator refactoring
[#2](#2)
([#2899](#2899))
([36e5340](36e5340))
* Refactor metrics/make API use binaries
([#2735](#2735))
([8ed086a](8ed086a))
* Remove prover db from house keeper
([#2795](#2795))
([85b7346](85b7346))
* **tee:** use hex serialization for RPC responses
([#2887](#2887))
([abe0440](abe0440))
* **utils:** Rework locate_workspace, introduce Workspace type
([#2830](#2830))
([d256092](d256092))
* vm2 tracers can access storage
([#3114](#3114))
([e466b52](e466b52))
* **vm:** Do not panic on VM divergence
([#2705](#2705))
([7aa5721](7aa5721))
* **vm:** EVM emulator support – base
([#2979](#2979))
([deafa46](deafa46))
* **vm:** Extract batch executor to separate crate
([#2702](#2702))
([b82dfa4](b82dfa4))
* **zk_toolbox:** `zk_supervisor prover` subcommand
([#2820](#2820))
([3506731](3506731))
* **zk_toolbox:** Add external_node consensus support
([#2821](#2821))
([4a10d7d](4a10d7d))
* **zk_toolbox:** Add SQL format for zk supervisor
([#2950](#2950))
([540e5d7](540e5d7))
* **zk_toolbox:** deploy legacy bridge
([#2837](#2837))
([93b4e08](93b4e08))
* **zk_toolbox:** Redesign zk_toolbox commands
([#3003](#3003))
([114834f](114834f))
* **zkstack_cli:** Build dependencies at zkstack build time
([#3157](#3157))
([724d9a9](724d9a9))


### Bug Fixes

* allow compilation under current toolchain
([#3176](#3176))
([89eadd3](89eadd3))
* **api:** Return correct flat call tracer
([#2917](#2917))
([218646a](218646a))
* count SECP256 precompile to account validation gas limit as well
([#2859](#2859))
([fee0c2a](fee0c2a))
* Fix Doc lint.
([#3158](#3158))
([c79949b](c79949b))
* ignore unknown fields in rpc json response
([#2962](#2962))
([692ea73](692ea73))
* **prover:** Do not exit on missing watcher data.
([#3119](#3119))
([76ed6d9](76ed6d9))
* **prover:** fix setup_metadata_to_setup_data_key
([#2875](#2875))
([4ae5a93](4ae5a93))
* **prover:** Run for zero queue to allow scaling down to 0
([#3115](#3115))
([bbe1919](bbe1919))
* **tee_verifier:** correctly initialize storage for re-execution
([#3017](#3017))
([9d88373](9d88373))
* **vm:** Prepare new VM for use in API server and fix divergences
([#2994](#2994))
([741b77e](741b77e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilLuta EmilLuta EmilLuta left review comments

@popzxc popzxc popzxc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Artemka374 @popzxc @EmilLuta