Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: block explorer module, command improvements #65

Merged
merged 16 commits into from
Oct 18, 2023

Conversation

JackHamer09
Copy link
Member

@JackHamer09 JackHamer09 commented Oct 10, 2023

What πŸ’»

  • Added Block Explorer module as an option
  • Improved info logs
  • Added support for stopping/restarting/cleaning only single module

Why βœ‹

  • Block Explorer module added for an easy local setup
  • Make information logs easier to read
  • In case you want to clean/stop/restart a single module, like Block Explorer, you can now do that with zksync-cli dev stop [module-name]

Evidence πŸ“·

image

Notes πŸ“

@JackHamer09 JackHamer09 changed the title feat: block explorer module, command improvements (WIP) feat: block explorer module, command improvements Oct 13, 2023
@JackHamer09 JackHamer09 marked this pull request as ready for review October 13, 2023 13:33
@JackHamer09 JackHamer09 requested a review from a team as a code owner October 13, 2023 13:33
@JackHamer09 JackHamer09 marked this pull request as draft October 13, 2023 15:58
@JackHamer09
Copy link
Member Author

JackHamer09 commented Oct 13, 2023

Issues found on windows for BE module, so the update is postponed until these issues are fixed.

UPD: All issues resolved

@JackHamer09 JackHamer09 marked this pull request as ready for review October 17, 2023 16:22
Copy link
Contributor

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hit this issue during setup @JackHamer09 :

Please make sure you have the correct access rights
and the repository exists.
β“˜ There was an error while starting the testing environment:
β“˜ Command exited with code 128:

Steps ran:

  1. Install deps
  2. Build
  3. ./bin/index.js dev config - Choose local-setup + BE
  4. ./bin/index.js dev start

@dutterbutter
Copy link
Contributor

I hit this issue during setup @JackHamer09 :

Please make sure you have the correct access rights
and the repository exists.
β“˜ There was an error while starting the testing environment:
β“˜ Command exited with code 128:

Steps ran:

  1. Install deps
  2. Build
  3. ./bin/index.js dev config - Choose local-setup + BE
  4. ./bin/index.js dev start

This was due to my environment setup. Not an issue.

@JackHamer09 JackHamer09 merged commit a535d5e into main Oct 18, 2023
2 checks passed
@JackHamer09 JackHamer09 deleted the dr-devrl-321-add-block-explorer-module-to-zkcli branch October 18, 2023 13:46
@github-actions
Copy link

πŸŽ‰ This PR is included in version 0.7.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants