fix: conversion for values #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsacoyote
force-pushed
the
itsacoyote-devrl-806-deposit-and-withdraw-amount-formatting
branch
from
f5bdd51 to
b712d53
Compare
JackHamer09
requested changes
Jul 27, 2024
@JackHamer09 Yeah I'd like to setup CI for testing but might consider that in another PR to focus on. This is just a tiny single test to make sure I didn't break anything with the new changes. I'll do another PR to properly set up a testing environment for the project later. |
JackHamer09
approved these changes
Jul 29, 2024
itsacoyote
deleted the
itsacoyote-devrl-806-deposit-and-withdraw-amount-formatting
branch
|
🎉 This PR is included in version 1.8.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Create a function that defines the token decimals for conversion between bigNumber and decimals.
The
bridge withdrawandbridge depositwere missing the token decimals for the transaction call. This will fix both commands.Why ✋
Define one time at the beginning the token decimals for the conversion functions will avoid forgetting to use the decimals when converting tokens that may not use the default 18 decimals like ETH does.
Added tests for sanity checks.