Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add quickstart template options #132

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

dutterbutter
Copy link
Contributor

@dutterbutter dutterbutter commented Apr 24, 2024

Opening this as a DRAFT PR so we can first have a discussion / review and then I may proceed to update the templates from personal repos to official templates repo.

Some discussion points:

  • Previous conversation we discussed "hiding" the quickstart templates from the template option list, do you think this is necessary?
  • Any suggestions on preferred naming convention on templates value. Currently using qs (short for quickstart), followed by guide. For example qs-testing for the quickstart testing template.

Relevant PR: matter-labs/zksync-contract-templates#11

What 💻

  • Adds quickstart templates option

Why ✋

  • Easy onboarding for new docs site

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes 📝

  • Any notes/thoughts that the reviewers should know prior to reviewing the code?

@JackHamer09
Copy link
Member

@dutterbutter LGTM

@dutterbutter dutterbutter marked this pull request as ready for review April 25, 2024 14:13
@dutterbutter dutterbutter requested a review from a team as a code owner April 25, 2024 14:13
@JackHamer09 JackHamer09 merged commit 22c1af7 into main Apr 29, 2024
2 checks passed
@JackHamer09 JackHamer09 deleted the db/quickstart-templates branch April 29, 2024 11:24
itsacoyote pushed a commit to matter-labs/zksync-docs that referenced this pull request May 6, 2024
Leaving as a DRAFT until the following PRs are merged:
- matter-labs/zksync-cli#132
- matter-labs/zksync-contract-templates#11

# What 💻 
* Uses zksync-cli for quickstart bootstrapping

# Why ✋
* Easiest way to get started

# Evidence 📷
Include screenshots, screen recordings, or `console` output here
demonstrating that your changes work as intended

<!-- All sections below are optional. You can uncomment any section
applicable to your Pull Request. -->

<!-- # Notes 📝
* Any notes/thoughts that the reviewers should know prior to reviewing
the code? -->
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants