Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token off-chain data fetcher incorrectly updates native tokens #350

Open
Romsters opened this issue Dec 4, 2024 · 1 comment
Open

Token off-chain data fetcher incorrectly updates native tokens #350

Romsters opened this issue Dec 4, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Romsters
Copy link
Collaborator

Romsters commented Dec 4, 2024

🐛 Bug Report

📝 Description

The off-chain token data fetching flow doesn't work correctly when coingecko has multiple tokens (L1 bridged + Native) under the same token id. Fix the script to update both native and bridged tokens in the DB.

🔄 Reproduction Steps

Example: USDC/USDC.e token.

🤔 Expected Behavior

Both native and bridged token should be updated.

😯 Current Behavior

Native token is not updated.

Might be worth looking into #287 first.

@Romsters Romsters added the bug Something isn't working label Dec 4, 2024
@kiriyaga-txfusion kiriyaga-txfusion self-assigned this Dec 16, 2024
@kiriyaga-txfusion
Copy link

Hello @Romsters,
Upon investigation, I don't see any issues here. Could you provide more context regarding when these prices appear incorrect? In the implementation, we handle bridged tokens by comparing L1 addresses with the token.platforms.ethereum data from CoinGecko and saving them into the database accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants