Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

og:url should be based off the site url setting instead of the url in the browser #18

Open
jstebenne opened this issue Feb 12, 2021 · 1 comment

Comments

@jstebenne
Copy link

Here is our current setup:

We do local development and pages update, and we access the website with localhost as the address. The admin UI is only installed in our local environment and is not included in the dockerfile of our production environment. So it is not possible to login and edit anything through the internet.

The problem:

With a setup like that, there is no way to generate metadata from the real URL. I would have thought that the URL field in the plugin settings would be used to build og:url but it still writes localhost.

Suggested change:

Use the URL field in the plugin's settings as the base for anything related to the URL. The field is already mandatory so I don't think there should be an impact anywhere.

@Karmalakas
Copy link
Contributor

Not sure this would work for multi-language sites. Especially if different languages are on different subdomains or even domains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants