-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New plugin Gitty for Github #815
Conversation
updated image url path fixed some syntax issues
We generally require that a plugin be contained within a single file. The plugin repo (and generally Bitbar) are not designed to handle multi-file scripts or scripts with dependancies/resources. I'll admit this is a pretty cool way to make that work anyway, but I'm not comfortable merging this in as is. I've tagged @matryer to take a look. |
Let me know if you wish for it all to be in a single file. Thanks for your feedback. |
@collegboi we do. It has lots of benefits, including simplicity. |
@tresni The build failed due to PIP not found. Can you re-run the tests? |
Looks like there may have been a change to how pip shows up on Travis. I'll investigate and rerun once I think I have it resolved. |
View tags, branches
This is due to Homebrew/homebrew-core#14408 which changed python executables to now be named x2 (e.g. python2, pip2, etc) I'll fix the test scripts and see what we can do. You may need to rebase your changes once I get the test script fixed. |
Dev/Gitty/git_python.5m.py
Outdated
# <bitbar.version>v0.1</bitbar.version> | ||
# <bitbar.author>Timothy Barnard</bitbar.author> | ||
# <bitbar.author.github>collegboi</bitbar.author.github> | ||
# <bitbar.image>https://raw.githubusercontent.com/collegboi/Bitbar-Gitty/master/image1.png</bitbar.image> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image doesn't exist anymore. Should either replace it with one that does (recommended) or remove the metadata.
Checks fail due to the image metadata. I've commented on. Otherwise you can either rebase on the current master or just push the necessary change and I'll test locally. |
I created a new plugin called Gitty, which finds your local repos and shows the status.