Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring]: improve lockMetaTable in compile #20721

Closed
ouyuanning opened this issue Dec 11, 2024 · 0 comments
Closed

[Refactoring]: improve lockMetaTable in compile #20721

ouyuanning opened this issue Dec 11, 2024 · 0 comments
Assignees
@ouyuanning
Labels
kind/refactor Code refactor priority/p0 Critical feature that should be implemented in this version
Milestone
2.0.2

Comments

@ouyuanning
Copy link
Contributor

Why do you want to refactor this code?

1、目前lockMetaTable的时候，会每次都生成一个vector，使用后free，可以修改为在prepare下复用这个vector。
2、去掉在lockMetaTable时候获取relation的操作。因为它并非必须，当需要的时候，lockRows会对去根据需要重新获取relation

Describe the solution you'd like

同上

Describe alternatives you've considered

No response

Additional information

No response
@ouyuanning ouyuanning added the kind/refactor Code refactor label Dec 11, 2024
@ouyuanning ouyuanning added this to the 2.0.2 milestone Dec 11, 2024
@ouyuanning ouyuanning self-assigned this Dec 11, 2024
@ouyuanning ouyuanning added the priority/p0 Critical feature that should be implemented in this version label Dec 11, 2024
This was referenced Dec 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouyuanning ouyuanning

Labels
kind/refactor Code refactor priority/p0 Critical feature that should be implemented in this version
Projects
None yet
Milestone
2.0.2
Development

No branches or pull requests
1 participant
@ouyuanning