Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring]: call lockMoTable once in Compile.lockMetaTables #20622

Closed
ouyuanning opened this issue Dec 6, 2024 · 0 comments
Closed

[Refactoring]: call lockMoTable once in Compile.lockMetaTables #20622

ouyuanning opened this issue Dec 6, 2024 · 0 comments
Assignees
@ouyuanning
Labels
kind/refactor Code refactor priority/p0.5
Milestone
2.1.0

Comments

@ouyuanning
Copy link
Contributor

Why do you want to refactor this code?

目前lockMetaTables中是根据本次query所涉及到的表，依次调用lockMoTable进行元数据表的上锁。
可以优化为，先构造好上锁的行，一次性lockRows。可以减少一些不必要的函数调用（如果锁服务在远端，应该也会省几次rpc请求）

Describe the solution you'd like

同上

Describe alternatives you've considered

No response

Additional information

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouyuanning ouyuanning

Labels
kind/refactor Code refactor priority/p0.5
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@ouyuanning @huby2358