Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech Request]: make sure all vector will be free correctly #16965

Closed
2 tasks done
ouyuanning opened this issue Jun 18, 2024 · 4 comments
Closed
2 tasks done

[Tech Request]: make sure all vector will be free correctly #16965

ouyuanning opened this issue Jun 18, 2024 · 4 comments
Assignees
@ouyuanning
Labels
kind/tech-request New feature or request priority/p0 Critical feature that should be implemented in this version to-next-release
Milestone
2.1.0

Comments

@ouyuanning
Copy link
Contributor

Is there an existing issue for the same tech request?

  • I have checked the existing issues.

Does this tech request not affect user experience?

  • This tech request doesn't affect user experience.

What would you like to be added ?

make sure all vector will be free correctly

Why is this needed ?

No response

Additional information

No response
@ouyuanning ouyuanning added kind/tech-request New feature or request priority/p0 Critical feature that should be implemented in this version labels Jun 18, 2024
@ouyuanning ouyuanning added this to the 1.3.0 milestone Jun 18, 2024
@ouyuanning ouyuanning self-assigned this Jun 18, 2024
@ouyuanning ouyuanning assigned reusee and unassigned ouyuanning Jul 24, 2024
@reusee reusee mentioned this issue Jul 24, 2024
Closed
@reusee
Copy link
Contributor

reusee commented Jul 24, 2024

working on this branch with missing free detector enabled: https://github.com/reusee/matrixone/tree/freevector

This was referenced Jul 24, 2024
Merged
Merged
Closed
@XuPeng-SH XuPeng-SH mentioned this issue Jul 24, 2024
Closed
1 task
@reusee
Copy link
Contributor

reusee commented Jul 24, 2024 •
edited
Loading

Recorded all Vecotr allocation paths that missed Free.

profile file:
profile.pb.gz

flamegraph:
Screenshot from 2024-07-24 14-00-43

reproduce steps:
build mo with this branch:
https://github.com/reusee/matrixone/tree/freevector
run TPCC
run TPCH
run go tool pprof -http :6060 'http:///missing-free-vector'

@reusee reusee mentioned this issue Jul 24, 2024
Merged
7 tasks
@ouyuanning
Copy link
Contributor Author

估计会比较长期的工作，不时就要筛一遍看看

@sukki37 sukki37 modified the milestones: 2.0.0, 2.1.0 Oct 14, 2024
@reusee
Copy link
Contributor

reusee commented Nov 1, 2024

vector会逐步切换到堆外分配，如果有未回收的，会导致OOM。等实际出现问题了，再单独提issue吧

@reusee reusee assigned ouyuanning and unassigned reusee Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouyuanning ouyuanning

Labels
kind/tech-request New feature or request priority/p0 Critical feature that should be implemented in this version to-next-release
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@reusee @ouyuanning @sukki37