[fix] : free all member of TxnComputationWrapper manually (#13783)

cherry-pick from : #13646 Approved by: @daviszhen, @qingxinhome, @sukki37
matrixorigin · Dec 26, 2023 · 25dae92 · 25dae92
1 parent c193191
commit 25dae92
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/pkg/frontend/computation_wrapper.go b/pkg/frontend/computation_wrapper.go
@@ -109,6 +109,15 @@ func (cwft *TxnComputationWrapper) GetAst() tree.Statement {
 	return cwft.stmt
 }
 
+func (cwft *TxnComputationWrapper) Free() {
+	cwft.plan = nil
+	cwft.proc = nil
+	cwft.ses = nil
+	cwft.compile = nil
+	cwft.runResult = nil
+	cwft.stmt = nil
+}
+
 func (cwft *TxnComputationWrapper) GetProcess() *process.Process {
 	return cwft.proc
 }

diff --git a/pkg/frontend/mysql_cmd_executor.go b/pkg/frontend/mysql_cmd_executor.go
@@ -3906,11 +3906,14 @@ func (mce *MysqlCmdExecutor) doComQuery(requestCtx context.Context, input *UserI
 		plans := make([]*plan.Plan, len(cws))
 		stmts := make([]tree.Statement, len(cws))
 		for i, cw := range cws {
-			if cwft, ok := cw.(*TxnComputationWrapper); ok && checkNodeCanCache(cwft.plan) {
-				plans[i] = cwft.plan
-				stmts[i] = cwft.stmt
-			} else {
-				return nil
+			if cwft, ok := cw.(*TxnComputationWrapper); ok {
+				if checkNodeCanCache(cwft.plan) {
+					plans[i] = cwft.plan
+					stmts[i] = cwft.stmt
+				} else {
+					cwft.Free()
+					return nil
+				}
 			}
 		}
 		ses.cachePlan(input.getSql(), stmts, plans)