Test unread counts in pushes #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't work because the check for the zero badge push looks like it's getting the content from the previous poke. Inspecting the pokes with -C, I can see they're correct. There are also more lost sequence futures than normal I think.
Turns out I was just confused and asserting the wrong thing. Also this changes the await_event so we wait for the receipt to be sent before continuing.
| ) | ||
| })->then( sub { | ||
| # Bob accepts the invite by joining the room | ||
| matrix_join_room( $bob, $room_id ) | ||
| })->then( sub { | ||
| await_event_for( $alice, filter => sub { | ||
| return 1; |
There was a problem hiding this comment.
You probably don't want to wait for any possible event, because that leads to fragile tests that get upset about things like spurious m.presence updates. Consider looking for just m.room.receipt events maybe?
Otherwise we risk flakiness because of getting presence events
Rather than an empty body, since this will set content-length etc for us. Also fix in the place I copied from...
|
ptal! :) |
|
LGTM. Though Jenkins appears unhappy. |
|
yeah, it needs matrix-org/synapse#705 so will wait until that's merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that unread counts increase and decrease correctly once messages and read receipts are sent respectively. Tests existing behaviour but uses event_id field added in https://github.com/matrix-org/synapse/pull/705/files