This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Port much of synapse.federation.federation_client to async/await
#6840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/federation_client_async
branch
from
799c03e
to
ea23210
Compare
erikjohnston
reviewed
Feb 5, 2020
|
|
||
| content = yield self._do_send_invite(destination, pdu, room_version) | ||
| content = await self._do_send_invite(destination, pdu, room_version) |
There was a problem hiding this comment.
Why isn't _do_send_invite async'ed?
There was a problem hiding this comment.
because I forgot it.
Done in 6bbd890.
There was a problem hiding this comment.
because I forgot it.
(For some reason I'm imaging you singing that to the tune of https://www.youtube.com/watch?v=D_XI_290cfw)
There was a problem hiding this comment.
Have you ever seen Billie Piper and me in the same room?
Co-Authored-By: Erik Johnston <[email protected]>
erikjohnston
approved these changes
Feb 5, 2020
48 tasks
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '577f46036': make FederationClient._do_send_invite async Apply suggestions from code review make FederationClient.send_invite async newsfile make FederationClient.get_missing_events async make FederationClient._do_send_leave async make FederationClient.send_leave.send_request async make FederationClient._do_send_join async make FederationClient.send_join.send_request async make FederationClient.make_membership_event.send_request async make FederationClient._try_destination_list async make FederationClient.send_leave async make FederationClient.send_join async make FederationClient.make_membership_event async make FederationClient.get_event_auth async make FederationClient.get_room_state_ids async make FederationClient.get_pdu async make FederationClient.backfill async
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another big async/await PR I'm afraid.
Based on #6837.