Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove unspecced and buggy PUT method on the unstable /rooms/<room_id>/batch_send endpoint. #15199

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Remove unspecced and buggy PUT method on the unstable /rooms/<room_id>/batch_send endpoint. #15199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/15199.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove unspecced and buggy `PUT` method on the unstable `/rooms/<room_id>/batch_send` endpoint.
16 changes: 1 addition & 15 deletions synapse/rest/client/room_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
import logging
import re
from http import HTTPStatus
from typing import TYPE_CHECKING, Awaitable, Tuple

from twisted.web.server import Request
from typing import TYPE_CHECKING, Tuple

from synapse.api.constants import EventContentFields
from synapse.api.errors import AuthError, Codes, SynapseError
Expand All @@ -30,7 +28,6 @@
parse_strings_from_args,
)
from synapse.http.site import SynapseRequest
from synapse.rest.client.transactions import HttpTransactionCache
from synapse.types import JsonDict

if TYPE_CHECKING:
Expand Down Expand Up @@ -79,7 +76,6 @@ def __init__(self, hs: "HomeServer"):
self.event_creation_handler = hs.get_event_creation_handler()
self.auth = hs.get_auth()
self.room_batch_handler = hs.get_room_batch_handler()
self.txns = HttpTransactionCache(hs)

async def on_POST(
self, request: SynapseRequest, room_id: str
Expand Down Expand Up @@ -249,16 +245,6 @@ async def on_POST(

return HTTPStatus.OK, response_dict

def on_GET(self, request: Request, room_id: str) -> Tuple[int, str]:
return HTTPStatus.NOT_IMPLEMENTED, "Not implemented"

def on_PUT(
self, request: SynapseRequest, room_id: str
) -> Awaitable[Tuple[int, JsonDict]]:
return self.txns.fetch_or_execute_request(
request, self.on_POST, request, room_id
)


def register_servlets(hs: "HomeServer", http_server: HttpServer) -> None:
msc2716_enabled = hs.config.experimental.msc2716_enabled
Expand Down