Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Prune mypy ignore_missing_imports list #12608

Merged
merged 20 commits into from
May 3, 2022
Merged

Prune mypy ignore_missing_imports list #12608

merged 20 commits into from
May 3, 2022

Commits on May 2, 2022

  1. Make use of canonicaljson's type annotations 

    Added by me in canonicaljson 1.6.1.
    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    5f139b8 View commit details
    Browse the repository at this point in the history

  2. The locked version of bcrypt has annotations

    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    4241e29 View commit details
    Browse the repository at this point in the history

  3. We haven't used daemonize since #8011.

    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    6162b2c View commit details
    Browse the repository at this point in the history

  4. Revert "Make use of canonicaljson's type annotations" 

    This reverts commit 5f139b8.
    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    14c4458 View commit details
    Browse the repository at this point in the history

  5. We don't seem to use h11 

    The ignore was added in #6023 (as was most of mypy.ini), but that change
appears unrelated. I can't find anywhere that we've ever used `h11` in
Synapse.
    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    9e94ff1 View commit details
    Browse the repository at this point in the history

  6. hiredis includes type stubs since v2.0.0 

    which is the version we have locked.
    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    87810fe View commit details
    Browse the repository at this point in the history

  7. hyperlink has type annotations since 20.0.0 

    We have 21.0.0 in our lockfile.
python-hyper/hyperlink@6313866
    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    8d23186 View commit details
    Browse the repository at this point in the history

  8. importlib-metadata has type annotations 

    In #12326 I added this config to get the tox mypy job to pass. It failed
on a630a0a (see
https://github.com/matrix-org/synapse/runs/5740930065?check_suite_focus=true)
because tox hadn't installed importlib_metadata at all.

Now that we're using the locked poetry environment, we don't have this
problem any more.
    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    a315212 View commit details
    Browse the repository at this point in the history

  9. jaegar_client has type annotations 

    or at least, has enough annotations for mypy to not complain about
missing imports.
    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    c72faf6 View commit details
    Browse the repository at this point in the history

  10. We don't use joespy 

    as of #10194
    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    2ee88b0 View commit details
    Browse the repository at this point in the history

  11. jwt has annotations since 2.0.0 

    We lock 2.3.0.

jpadilla/pyjwt#535
    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    3e274d2 View commit details
    Browse the repository at this point in the history

  12. pynacl has type annotations as of 1.5.0 

    thanks to someone!!
    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    d302773 View commit details
    Browse the repository at this point in the history

  13. phonenumbers has annotations since 8.12.32 

    We lock 8.12.44.
See daviddrysdale/python-phonenumbers#207
    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    b42c205 View commit details
    Browse the repository at this point in the history

  14. promethus_client is typed (enough) 

    as of v0.13.0
prometheus/client_python#705

we lock 0.14.0.
    David Robertson committed May 2, 2022
    Configuration menu
    Copy the full SHA
    400acd9 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Redbaron was removed from the release script 

    See a54d9b0
    David Robertson committed May 3, 2022
    Configuration menu
    Copy the full SHA
    68dd483 View commit details
    Browse the repository at this point in the history

  2. Recent signedjson has type annotations 

    thanks to me
    David Robertson committed May 3, 2022
    Configuration menu
    Copy the full SHA
    4c6c416 View commit details
    Browse the repository at this point in the history

  3. sentry_sdk seems to have py2-style type hints

    David Robertson committed May 3, 2022
    Configuration menu
    Copy the full SHA
    98a5069 View commit details
    Browse the repository at this point in the history

  4. typechecker seems to work without twisted and zope 

    presumably twisted is well-annotated enough now.
Twisted has a py.typed marker since about two years ago:
twisted/twisted@b7a1102
    David Robertson committed May 3, 2022
    Configuration menu
    Copy the full SHA
    9161ada View commit details
    Browse the repository at this point in the history

  5. drive-by netaddr stub comment

    David Robertson committed May 3, 2022
    Configuration menu
    Copy the full SHA
    d70493c View commit details
    Browse the repository at this point in the history

  6. changelog

    David Robertson committed May 3, 2022
    Configuration menu
    Copy the full SHA
    611d14a View commit details
    Browse the repository at this point in the history