Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

synapse 1.28rc1 breaks compat with SAML portal #9452

Closed
richvdh opened this issue Feb 19, 2021 · 1 comment
Closed

synapse 1.28rc1 breaks compat with SAML portal #9452

richvdh opened this issue Feb 19, 2021 · 1 comment
Assignees
@clokep
Labels
X-Release-Blocker Must be resolved before making a release

Comments

@richvdh
Copy link
Member

richvdh commented Feb 19, 2021 •
edited
Loading

one of our customers has a saml portal which expects synapse to respond to saml callbacks on /_matrix/saml2/authn_response. Since #9434, it doesn't.
@richvdh richvdh added the X-Release-Blocker Must be resolved before making a release label Feb 19, 2021
@callahad
Copy link
Contributor

We can partially revert #9434 easily enough to provide a transition period, but we shouldn't maintain that indefinitely.

Let's arbitrarily say we'll re-apply the change with Synapse 1.32, which will be our first full release in April and coincide with Python 3.5 deprecation.

@clokep clokep mentioned this issue Feb 23, 2021
Merged
@clokep clokep self-assigned this Feb 23, 2021
@clokep clokep closed this as completed Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
X-Release-Blocker Must be resolved before making a release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@callahad @clokep @richvdh