Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add type stubs for 3rd party packages #9228

Closed
clokep opened this issue Jan 26, 2021 · 2 comments
Closed

Add type stubs for 3rd party packages #9228

clokep opened this issue Jan 26, 2021 · 2 comments
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Jan 26, 2021

When mypy doesn't know what a type is it treats it as Any, this has lead to bugs that we thought mypy was catching. We should consider if we should flesh our more of our type hints from 3rd party modules instead of ignoring them.

There's also the https://github.com/python/typeshed/ project, but according to that README it is included in mypy. It doesn't seem like there's too many projects available in that TBH.
@clokep clokep mentioned this issue Jan 26, 2021
Merged
@clokep
Copy link
Member Author

clokep commented Jan 26, 2021

See the conversation around #9223 (comment) about this.

@clokep clokep added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jan 26, 2021
@clokep
Copy link
Member Author

clokep commented Dec 14, 2021

I'm going to say that #11006 has fixed this. Hopefully additional packages keep having stubs (or ship type hints), but I don't think this is actionable as-is.

@clokep clokep closed this as completed Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clokep