Unexpected error code for invalid param on "/_matrix/client/r0/publicRooms" endpoint

[poulad]

Description

API returns the error code M_UNKNOWN instead of M_INVALID_PARAM for an invalid parameter in the request.

Steps to reproduce

Call listing public rooms endpoint with the invalid type of parameter: string instead of integer for the limit.

curl "https://matrix.org/_matrix/client/r0/publicRooms?limit=NOT_INTEGER"

Expected Result

{
    "errcode": "M_INVALID_PARAM",
    "error": "Query parameter 'limit' must be an integer"
}

Actual Result

{
    "errcode": "M_UNKNOWN",
    "error": "Query parameter b'limit' must be an integer"
}

Version information

• Homeserver: matrix.og

[aaronraimist]

This was fixed

⟩ curl "https://matrix.org/_matrix/client/r0/publicRooms?limit=NOT_INTEGER"

{
    "errcode": "M_INVALID_PARAM",
    "error": "Query parameter b'limit' must be an integer"
}