Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Complement flake TestFederationKeyUploadQuery/Parallel/Can_query_remote_device_keys_using_POST #16020

Open
DMRobertson opened this issue Jul 28, 2023 · 18 comments · Fixed by matrix-org/complement#648 or matrix-org/complement#649
Open

Complement flake TestFederationKeyUploadQuery/Parallel/Can_query_remote_device_keys_using_POST #16020

DMRobertson opened this issue Jul 28, 2023 · 18 comments · Fixed by matrix-org/complement#648 or matrix-org/complement#649
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact Z-Flake Tests that give intermittent failures

Comments

@DMRobertson
Copy link
Contributor

Seen in #16018, namely https://github.com/matrix-org/synapse/actions/runs/5689189095/job/15420265614
@DMRobertson DMRobertson added Z-Flake Tests that give intermittent failures S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact O-Occasional Affects or can be seen by some users regularly or most users rarely O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jul 28, 2023
@DMRobertson DMRobertson mentioned this issue Jul 28, 2023
Closed
@DMRobertson
Copy link
Contributor Author

DMRobertson commented Aug 2, 2023 •
edited
Loading

https://github.com/matrix-org/synapse/actions/runs/5735750569/job/15544028079#step:5:6235 on develop+latestdeps, #16049

@DMRobertson DMRobertson mentioned this issue Aug 2, 2023
Closed
@DMRobertson
Copy link
Contributor Author 

       federation_upload_keys_test.go:112: MatchResponse key 'device_keys.@alice:hs1.HQSZVWDSZW.unsigned.device_display_name' missing - http://127.0.0.1:33361/_matrix/client/v3/keys/query => {"device_keys":{"@alice:hs1":{"HQSZVWDSZW":{"algorithms":["m.olm.v1.curve25519-aes-sha2","m.megolm.v1.aes-sha2"],"device_id":"HQSZVWDSZW","keys":{"curve25519:HQSZVWDSZW":"zHcxVx4cUhILr0RIFQbWm2QptV8cUpmJz6+yzREhEhU","ed25519:HQSZVWDSZW":"uubiIl3Re7WKps6W6S3fYOXSsrp+K9uEEOL4W7EUfSg"},"signatures":{"@alice:hs1":{"ed25519:HQSZVWDSZW":"a8SmLgqYuA9og+lKKQ9xc1W6yAC763s34qYpQMC7novGTNd1gnHj5Wln3q/C7618QuWNidImxaXWCEB7aUhGAA"}},"user_id":"@alice:hs1"}}},"failures":{},"master_keys":{},"self_signing_keys":{},"user_signing_keys":{}}

@DMRobertson
Copy link
Contributor Author

And https://github.com/matrix-org/synapse/actions/runs/5737293668/job/15548766143

@DMRobertson
Copy link
Contributor Author

Maybe related to #15975?

@clokep
Copy link
Member

clokep commented Aug 14, 2023

https://github.com/matrix-org/synapse/actions/runs/5851753987/job/15872401761?pr=16106

@clokep
Copy link
Member

clokep commented Aug 22, 2023

https://github.com/matrix-org/synapse/actions/runs/5938740638/job/16103891133?pr=16157

I seem to be getting this more frequently recently...

@clokep
Copy link
Member

clokep commented Aug 22, 2023

https://github.com/matrix-org/synapse/actions/runs/5921915531/job/16055233357?pr=16139

@clokep clokep mentioned this issue Aug 25, 2023
Closed
@clokep
Copy link
Member

clokep commented Aug 25, 2023

https://github.com/matrix-org/synapse/actions/runs/5979001067/job/16222343343?pr=16099

@DMRobertson
Copy link
Contributor Author

https://github.com/matrix-org/synapse/actions/runs/6004624574/job/16300956746?pr=16205

@DMRobertson
Copy link
Contributor Author

https://github.com/matrix-org/synapse/actions/runs/6015777989/job/16318426032

@DMRobertson
Copy link
Contributor Author

https://github.com/matrix-org/synapse/actions/runs/6016116523/job/16319481679?pr=16175 again

This was referenced Aug 30, 2023
Merged
Merged
@DMRobertson
Copy link
Contributor Author

I'm still seeing this today on https://github.com/matrix-org/synapse/actions/runs/6081842673/job/16498376137

@DMRobertson DMRobertson reopened this Sep 5, 2023
@DMRobertson DMRobertson mentioned this issue Sep 5, 2023
Closed
@erikjohnston
Copy link
Member

Well at least it's flaking at a different point now!

@erikjohnston
Copy link
Member

PR for a potential fix incoming

@erikjohnston
Copy link
Member

matrix-org/complement#649

@DMRobertson DMRobertson mentioned this issue Sep 5, 2023
Merged
@clokep clokep mentioned this issue Oct 26, 2023
Closed
@clokep
Copy link
Member

clokep commented Oct 26, 2023

This seems to have popped up again once: https://github.com/matrix-org/synapse/actions/runs/6650600407/job/18071014117 will leave closed until it becomes an issue.

@DMRobertson
Copy link
Contributor Author

Seen in https://github.com/matrix-org/synapse/actions/runs/6953944995/job/18919907563.

@DMRobertson DMRobertson reopened this Nov 22, 2023
@DMRobertson
Copy link
Contributor Author 

❌ TestFederationKeyUploadQuery/Can_query_remote_device_keys_using_POST (30ms)
      federation_upload_keys_test.go:131: MatchResponse key 'device_keys.@user-43:hs1.DAGGZUUSZR.unsigned.device_display_name' missing - http://127.0.0.1:32794/_matrix/client/v3/keys/query => {"device_keys":{"@user-43:hs1":{"DAGGZUUSZR":{"algorithms":["m.olm.v1.curve25519-aes-sha2","m.megolm.v1.aes-sha2"],"device_id":"DAGGZUUSZR","keys":{"curve25519:DAGGZUUSZR":"ANJuaBAjWyjfXKdSg6n1K2s0/sH6rG9h1VesVEUsbD4","ed25519:DAGGZUUSZR":"hYa1XxTgHHGDbJW7ZQSy5dZyfUCDRdl4lKBFhrBtTgY"},"signatures":{"@user-43:hs1":{"ed25519:DAGGZUUSZR":"ZB2UXJKNMN2DfJJRRlTNkQBrxIKw7wom6opqTTxK7xrJ/ChcEQ8JyGenwDnKO2UPMgR+VoCp9JaRspdHQlxXAA"}},"user_id":"@user-43:hs1","unsigned":{}}}},"failures":{},"master_keys":{},"self_signing_keys":{},"user_signing_keys":{}}

@DMRobertson DMRobertson mentioned this issue Nov 23, 2023
Closed
@matrixbot matrixbot mentioned this issue Dec 22, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact Z-Flake Tests that give intermittent failures
Projects
None yet
Milestone
No milestone
3 participants
@clokep @erikjohnston @DMRobertson