Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Support MSC4028 (Push all encrypted events except for muted rooms) #15847

Closed
Tracked by #2065
giomfo opened this issue Jun 28, 2023 · 0 comments · Fixed by #16361
Closed
Tracked by #2065

Support MSC4028 (Push all encrypted events except for muted rooms) #15847

giomfo opened this issue Jun 28, 2023 · 0 comments · Fixed by #16361
Assignees
Labels
A-Push Issues related to push/notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@giomfo
Copy link
Member

giomfo commented Jun 28, 2023

Description

The purpose of MSC4028 is to be able to support on mobile clients the "mentions-and-keywords-only" room notification setting in encrypted rooms. This MSC adds a new "server-default" override push rule (.m.rule.encrypted_event) in order to force the server to push all encrypted events to the registered client except for muted room.

I request here to add this new "server-default" push rule with its unstable id org.matrix.msc4028.encrypted_event. Contrary to the stable push rule, this unstable one should not be enabled -> its enabled attribute must be false. Indeed we should not turn it on until the clients implementations are ready.

I listed here the potential issues of this MSC server side. We talked about them in an internal discussion, the conclusion was:

So calculating what to push and the unread counts (its the same process) is a big performance bottleneck currently when sending in large rooms. A bunch of optimisation has taken place to make that better, but its still quite expensive
I'm not so concerned about /sync, as we've mostly already done the work at that point

I would let the backend team use this issue or create new ones to handle any other dev related to this MSC.

@clokep clokep added S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jun 28, 2023
@MadLittleMods MadLittleMods added the A-Push Issues related to push/notifications label Jun 28, 2023
@clokep clokep self-assigned this Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Push Issues related to push/notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants