Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Include x_forwarded in workers sample config files #14653

Closed
villepeh opened this issue Dec 11, 2022 · 1 comment · Fixed by #14667
Closed

Include x_forwarded in workers sample config files #14653

villepeh opened this issue Dec 11, 2022 · 1 comment · Fixed by #14667
Labels
A-Config Configuration, or the documentation thereof A-Docs things relating to the documentation A-Workers Problems related to running Synapse in Worker Mode (or replication) O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution

Comments

@villepeh
Copy link
Contributor

Description:

I didn't want to create a pull request on this yet because there's a chance I missed something.

I suppose almost everyone runs a reverse proxy when using workers that utilize a HTTP listener. However, none of the worker sample config files include the x_forwarded setting which reads the value of X-Forwarded-For.

If I understood it right, without setting x_forwarded on worker configs, the servers that have moved pretty much everything to the workers never get the users' actual IPs, showing 127.0.0.1 on all their sessions.

If the XFF "magic" is handled some other way with the workers then this issue is useless :) but if not, I can create a PR that'll add the setting to the relevant sample config files.

@squahtx
Copy link
Contributor

squahtx commented Dec 12, 2022

That sounds about right. It's hard to imagine anyone using workers without a reverse proxy. A PR would be much appreciated.

@squahtx squahtx added A-Docs things relating to the documentation A-Workers Problems related to running Synapse in Worker Mode (or replication) A-Config Configuration, or the documentation thereof S-Tolerable Minor significance, cosmetic issues, low or no impact to users. O-Occasional Affects or can be seen by some users regularly or most users rarely Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Config Configuration, or the documentation thereof A-Docs things relating to the documentation A-Workers Problems related to running Synapse in Worker Mode (or replication) O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants