This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Include x_forwarded
in workers sample config files
#14653
Labels
A-Config
Configuration, or the documentation thereof
A-Docs
things relating to the documentation
A-Workers
Problems related to running Synapse in Worker Mode (or replication)
O-Occasional
Affects or can be seen by some users regularly or most users rarely
S-Tolerable
Minor significance, cosmetic issues, low or no impact to users.
T-Task
Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Z-Help-Wanted
We know exactly how to fix this issue, and would be grateful for any contribution
Description:
I didn't want to create a pull request on this yet because there's a chance I missed something.
I suppose almost everyone runs a reverse proxy when using workers that utilize a HTTP listener. However, none of the worker sample config files include the
x_forwarded
setting which reads the value of X-Forwarded-For.If I understood it right, without setting
x_forwarded
on worker configs, the servers that have moved pretty much everything to the workers never get the users' actual IPs, showing 127.0.0.1 on all their sessions.If the XFF "magic" is handled some other way with the workers then this issue is useless :) but if not, I can create a PR that'll add the setting to the relevant sample config files.
The text was updated successfully, but these errors were encountered: