Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Track apdex by "class" of room #13316

Open
erikjohnston opened this issue Jul 18, 2022 · 2 comments
Open

Track apdex by "class" of room #13316

erikjohnston opened this issue Jul 18, 2022 · 2 comments
Labels
A-Metrics metrics, measures, stuff we put in Prometheus T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact

Comments

@erikjohnston
Copy link
Member

Occasionally we see send time issues in e.g. large rooms, which is not reflected in the global apdex (as the traffic isn't high enough proportion of the total request count).

To help surface these issues we could have a separate metric that separates the apdex by the "class" of room, e.g. small rooms (<10 members), medium rooms (10 to 1000 members), large rooms (1000+), and maybe extra large rooms (10,000+)

@erikjohnston erikjohnston added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Jul 18, 2022
@clokep
Copy link
Member

clokep commented Jul 18, 2022

small rooms (<10 members), medium rooms (10 to 1000 members), large rooms (1000+), and maybe extra large rooms (10,000+)

Might also make sense to specifically have DMs (i.e. 2 members).

@MadLittleMods MadLittleMods added the A-Metrics metrics, measures, stuff we put in Prometheus label Apr 25, 2023
@MadLittleMods
Copy link
Contributor

We did this for the /messages response time in #13545:

if member_count <= 2:
    return _RoomSize.DM_SIZE
elif member_count < 100:
    return _RoomSize.SMALL
elif member_count < 1000:
    return _RoomSize.SUBSTANTIAL
else:
    return _RoomSize.LARGE

@MadLittleMods MadLittleMods added the Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact label Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Metrics metrics, measures, stuff we put in Prometheus T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact
Projects
None yet
Development

No branches or pull requests

3 participants