Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Changelog for PR #12738.
Browse files Browse the repository at this point in the history
  • Loading branch information
Danieloni1 committed May 15, 2022
1 parent 677c763 commit f3eedf0
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions changelog.d/12738.type
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Currently when a user attempts login before registration, we respond with 403 and an empty string message.
In cases where a user was registered and bound to a 3pid already, we return "Invalid Password" as a message.
2 issues arise from this behavior:
- The major one is user existence leak. Having 2 different error messages for unregistered users and registered users who've entered the wrong password essentially leaks the information about that particular user's existence.
- While another issue is having a non-informative error message in the current approach. As the user wasn't yet registered, it has no password, so essentially no password is valid, implying the need to return "Invalid Password" instead of just "".

Contributed by Daniel Aloni.

0 comments on commit f3eedf0

Please sign in to comment.