Fix http/s proxy authentication

Signed-off-by: magic_rb <[email protected]>
matrix-org · Oct 20, 2023 · 4f69a64 · 4f69a64
1 parent 7291c68
commit 4f69a64
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog.d/16504.bugfix b/changelog.d/16504.bugfix
@@ -0,0 +1 @@
+Fix http/s forward proxy authentication not working.
diff --git a/synapse/http/connectproxyclient.py b/synapse/http/connectproxyclient.py
@@ -59,7 +59,9 @@ def as_proxy_authorization_value(self) -> bytes:
             a Proxy-Authorization header.
         """
         # Encode as base64 and prepend the authorization type
-        return b"Basic " + base64.encodebytes(self.username_password)
+        return b"Basic " + base64.encodebytes(self.username_password).replace(
+            b"\n", b""
+        )
 
 
 @attr.s(auto_attribs=True)