Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3_media_upload should report number of files skipped due to already being on S3 #75

Open
richvdh opened this issue Aug 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@richvdh
Copy link
Member

richvdh commented Aug 26, 2022

This makes for alarming reading:

Aug 25 00:51:50 hippogriff.matrix.org synapse_media_upload[7417]: Uploading/deleting media for media_store
Aug 25 02:04:06 hippogriff.matrix.org synapse_media_upload[7417]: Uploading  92323  files
Aug 25 02:04:06 hippogriff.matrix.org synapse_media_upload[7417]: Uploaded 0 media out of 92323
Aug 25 02:04:06 hippogriff.matrix.org synapse_media_upload[7417]: Uploaded 0 files
Aug 25 02:04:06 hippogriff.matrix.org synapse_media_upload[7417]: Uploaded 0B
Aug 25 02:04:06 hippogriff.matrix.org synapse_media_upload[7417]: Deleted 92323 media

you deleted 92323 media without uploading any of them??

Presumably, these files already existed on S3. Generally the logging here could do with clarifying (what's the difference between a media and a file, and why are their counts logged separately?), but in particular it would be good to keep a count of "already existing" media (or files?) so that we can check that the numbers add up.

@DMRobertson DMRobertson added the enhancement New feature or request label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants