Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

mypy is failing in CI #89

Closed
anoadragon453 opened this issue Mar 18, 2021 · 2 comments
Closed

mypy is failing in CI #89

anoadragon453 opened this issue Mar 18, 2021 · 2 comments

Comments

@anoadragon453
Copy link
Member

Due to the same problem we were affected with on mainline: matrix-org/synapse#9513

Suggest we downgrade twisted until we rebase Synapse on a version with the fixes implemented.
@anoadragon453 anoadragon453 mentioned this issue Mar 19, 2021
Merged
@anoadragon453
Copy link
Member Author

#90 is the PR to perform the downgrade.

People running mypy will need to run pip install -U Twisted==20.3.0 to do the same locally.

@babolivier
Copy link
Contributor

Doesn't look like this is an issue anymore: https://github.com/matrix-org/synapse-dinsic/runs/4446981793?check_suite_focus=true

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anoadragon453 @babolivier