-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't ban users in moderator room #544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise generally lgtm. Tests would also be good, if possible
d5e7fc8
to
fac9f2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's give it a go.
294b25c
to
c7aad5c
Compare
@turt2live can you just double-check the fix for the appservice test looks good before I merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
Prevents the bot from banning itself/other users in the moderator room. Also adds a command to add others who are not in room to list of entities that shouldn't be banned/ACL'd.
Reviewable commit-by-commit.