Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ban users in moderator room #544

Merged
merged 13 commits into from
Oct 21, 2024
Merged

Don't ban users in moderator room #544

merged 13 commits into from
Oct 21, 2024

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Oct 9, 2024

Prevents the bot from banning itself/other users in the moderator room. Also adds a command to add others who are not in room to list of entities that shouldn't be banned/ACL'd.

Reviewable commit-by-commit.

@H-Shay H-Shay requested a review from turt2live October 9, 2024 21:40
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise generally lgtm. Tests would also be good, if possible

src/Mjolnir.ts Outdated Show resolved Hide resolved
src/Mjolnir.ts Outdated Show resolved Hide resolved
src/commands/CommandHandler.ts Outdated Show resolved Hide resolved
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's give it a go.

@H-Shay H-Shay requested a review from a team as a code owner October 21, 2024 19:06
@H-Shay
Copy link
Contributor Author

H-Shay commented Oct 21, 2024

@turt2live can you just double-check the fix for the appservice test looks good before I merge this?

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@H-Shay H-Shay merged commit 93282da into main Oct 21, 2024
5 checks passed
@H-Shay H-Shay deleted the shay/no_self_harm branch October 21, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants