Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When linking to the Matrix Public Archive, make sure URL previews look good #202

Open
MadLittleMods opened this issue Apr 29, 2023 · 1 comment
Open

When linking to the Matrix Public Archive, make sure URL previews look good #202

MadLittleMods opened this issue Apr 29, 2023 · 1 comment
Labels
help wanted PR's welcome to fix this issue. It probably has a potential solution documented in the issue. T-Enhancement New feature or request
Milestone
Matrix Public Arc...

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Apr 29, 2023 •
edited
Loading

If someone links to the Matrix Public Archive, we should make sure the URL previews look good.

When linking the homepage, a sensible description and image

When linking to a specific event, the URL preview should show the event contents:

.../r/foo.bar/date/2022/11/01?at=$abcd

When linking to a room on a given day, TODO

.../r/foo.bar/date/2022/11/01

When linking to a room, TODO

.../r/foo.bar

Dev notes

Synapse URL preview:

References:

URL preview debuggers:
@MadLittleMods MadLittleMods added T-Enhancement New feature or request A-archive-room-view The view to look at a room day by day in the archive help wanted PR's welcome to fix this issue. It probably has a potential solution documented in the issue. labels Apr 29, 2023
@MadLittleMods
Copy link
Contributor Author

@clokep Any tips for what we need to add to the page (<meta>)? What drives the URL preview in Element (title, description, image)?

Pinging you because I recall you caring about them and poking around whenever you see a bad one.

MadLittleMods added a commit that referenced this issue May 5, 2023
@MadLittleMods
Add some <meta name="description" ...> to pages
1cdb8ef 
Part of #202
@MadLittleMods MadLittleMods mentioned this issue May 5, 2023
Merged
@MadLittleMods MadLittleMods removed the A-archive-room-view The view to look at a room day by day in the archive label May 5, 2023
MadLittleMods added a commit that referenced this issue May 5, 2023
@MadLittleMods
Add some <meta name="description" ...> to pages (#214)
aeceb19 
Not the best but probably better than the default (a good first iteration)

Part of #202
@MadLittleMods MadLittleMods mentioned this issue May 10, 2023
Merged
MadLittleMods added a commit that referenced this issue May 10, 2023
@MadLittleMods
Add image metadata for URL previews (#224)
16323df 
 - Default to a nice `[matrix]` banner
    -  There is room for improvement here when the Matrix Public Archive gets it's own logo (#94) and maybe says "Matrix Public Archive" somewhere in the banner.
    - This is good enough for now (and certainly better than downstream previews using the first image on the page).
 - For rooms, it will use the room avatar

Part of #202

Image is sized to 1200x630 to match conventions of `og:image`.

Crafted the banner image by modifying the header on the room directory homepage and taking a node screenshot. Page zoom @ 175%
@MadLittleMods MadLittleMods mentioned this issue May 10, 2023
Merged
MadLittleMods added a commit that referenced this issue May 10, 2023
@MadLittleMods
Better grammar in URL preview description (#225)
1a140b3 
Part of #202
@MadLittleMods MadLittleMods mentioned this issue May 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted PR's welcome to fix this issue. It probably has a potential solution documented in the issue. T-Enhancement New feature or request
Projects
None yet
Milestone
Matrix Public Archive v(next)
Development

No branches or pull requests
1 participant
@MadLittleMods