Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar Support #108

Open
Turakar opened this issue Sep 8, 2020 · 9 comments
Open

Avatar Support #108

Turakar opened this issue Sep 8, 2020 · 9 comments

Comments

@Turakar
Copy link

Turakar commented Sep 8, 2020

I would enjoy the support for Avatars via the jpegPhoto attribute in LDAP. As far as I can tell there is no discussion on this yet. The design decisions by Nextcloud might be a good starting point. What are your thoughts on this?

@nE0sIghT
Copy link
Contributor

nE0sIghT commented Oct 13, 2020

As for now Synapse doesn't expose any method/property to obtain ProfileManager [1] from account_handler [2][3]. And we need ProfileManager to change avatar.
Technicaly we can use account_handler._hs.get_profile_handler(), but I don't think it will be acceptable PR...
It's also not clear for me now how to store avatar since ProfileManager allows to set avatar URL only so image itself should be stored at HS somehow (so we need some more API calls).

Any Matrix devs here with some advice? Does usage of "private" account_handler._hs is acceptable?

[1] https://github.com/matrix-org/synapse/blob/develop/synapse/handlers/profile.py#L38
[2] https://github.com/matrix-org/synapse/blob/develop/synapse/handlers/auth.py#L173
[3] https://github.com/matrix-org/synapse/blob/develop/synapse/module_api/__init__.py#L41

@clokep
Copy link
Member

clokep commented Oct 13, 2020

Any Matrix devs here with some advice? Does usage of "private" account_handler._hs is acceptable?

This would not be acceptable. I think we'd first need to do a PR to add the proper APIs to ModuleApi.. If we were to do this, we should probably also support display name at the same time since most of the code will be identical?

@clokep
Copy link
Member

clokep commented Nov 23, 2020

#110 also mentions using "thumbnailPhoto (type: binary, image-type: jpeg)".

@Half-Shot
Copy link
Contributor

This depends on matrix-org/synapse#7734. While that issue mentions display names, it would presumably be trivial to also allow avatar updates too. In terms of uploading the media, we would need to consider how to work with external media repos as services like EMS do not use the Synapse media repo.

@ankar84
Copy link

ankar84 commented Oct 22, 2021

support for Avatars via the jpegPhoto attribute in LDAP

Definitely must have feature for such great project as Matrix!

@helmut72
Copy link

LDAP support feels half complete, if users need to manually add their avatar.

@xfn2020
Copy link

xfn2020 commented Mar 25, 2022

When expect avatar support?

@soupglasses
Copy link

The upstream OIDC now has to support for avatars. While url based, it could be of inspiration? matrix-org/synapse#9357

@eXtrem0us

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants