Clarify that the async upload endpoint will return 404 in some cases #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
I was made aware by @tulir that this omission was due to a spec writing error when translating MSC2246 to a spec PR, rather than a point missing from the original MSC. The MSC says:
If the serverName/mediaId combination is not known, not local, or expired, an
M_NOT_FOUNDerror is returned.
While this doesn't explicitly say 404, it's very much implied. @tulir is also the author of the MSC 🙃
|
Thank you for your contribution @bnjbvr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Preview: https://pr1983--matrix-spec-previews.netlify.app